Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): add brownfield testcase #164

Merged
merged 11 commits into from
Sep 5, 2023
Merged

test(e2e): add brownfield testcase #164

merged 11 commits into from
Sep 5, 2023

Conversation

bogdanNovikovDell
Copy link
Contributor

@bogdanNovikovDell bogdanNovikovDell commented Aug 30, 2023 •
edited by shanduur-dell
Loading

Description

Added brownfield provisioning tests to COSI.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit testing
  • Integration testing

Special Notes For Your Reviewer:

Please describe the parts of code reviewers should focus on.

Additional documentation

  • Enhancement proposals
  • Usage documentation

shanduur-dell
shanduur-dell reviewed Aug 30, 2023
View reviewed changes
Copy link
Contributor

@shanduur-dell shanduur-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, test Grant Bucket Access to Brownfield bucket.

tests/integration/bucket_creation_suite_test.go Outdated Show resolved Hide resolved
tests/integration/bucket_creation_suite_test.go Outdated Show resolved Hide resolved
@csmbot
Copy link
Collaborator

csmbot commented Aug 30, 2023

Can one of the admins verify this patch?

@shanduur-dell shanduur-dell marked this pull request as ready for review August 31, 2023 09:55
@shanduur-dell shanduur-dell self-requested a review August 31, 2023 09:56
@shanduur-dell shanduur-dell force-pushed the brownfield_test branch 2 times, most recently from c0a87a9 to 00c2eea Compare September 1, 2023 10:43
mdutka-dell
mdutka-dell approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@mdutka-dell mdutka-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cbartoszDell
Copy link
Contributor

LGTM

@shanduur-dell shanduur-dell changed the title add brownfield testcase test(e2e): add brownfield testcase Sep 5, 2023
@shanduur-dell shanduur-dell merged commit 43b510c into main Sep 5, 2023
7 checks passed
@shanduur-dell shanduur-dell deleted the brownfield_test branch September 5, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbartoszDell cbartoszDell cbartoszDell approved these changes

@mdutka-dell mdutka-dell mdutka-dell approved these changes

@adamginna-dell adamginna-dell Awaiting requested review from adamginna-dell

@mtrajfacki-dell mtrajfacki-dell Awaiting requested review from mtrajfacki-dell

@mareksuski-dell mareksuski-dell Awaiting requested review from mareksuski-dell

@Leonard-Dell Leonard-Dell Awaiting requested review from Leonard-Dell

@shanduur-dell shanduur-dell Awaiting requested review from shanduur-dell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bogdanNovikovDell @csmbot @cbartoszDell @shanduur-dell @mdutka-dell