Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle segmentation violation #68

Merged
merged 3 commits into from
Nov 29, 2023
Merged

Conversation

nitesh3108
Copy link
Contributor

@nitesh3108 nitesh3108 commented Nov 28, 2023

Description

Added a nil check to skip processing pvs without ClaimRef. This will prevent karavi-metrics-powerscale from crashing when there are unbound pv s in clusters

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1019

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make unit test results
    image
  • topology test passed
    image
  • metrics test passed
    image

@csmbot
Copy link
Collaborator

csmbot commented Nov 28, 2023

Can one of the admins verify this patch?

@donatwork
Copy link
Contributor

Looks like the unit tests is below 90% in one package.

@shefali-malhotra
Copy link
Contributor

Updated the metrics e2e and topology test cases screenshot

@rajendraindukuri
Copy link
Collaborator

skip e2e test

@rajendraindukuri
Copy link
Collaborator

e2e pass

Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donatwork
Copy link
Contributor

skip e2e test

@rajendraindukuri
Copy link
Collaborator

e2e pass

@rajendraindukuri rajendraindukuri self-requested a review November 29, 2023 09:57
@rajendraindukuri
Copy link
Collaborator

skip e2e test

@donatwork
Copy link
Contributor

e2e pass

@shefali-malhotra shefali-malhotra merged commit cafa894 into main Nov 29, 2023
8 checks passed
@shefali-malhotra shefali-malhotra deleted the segmentation-violation-error branch November 29, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants