Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multistage image build for powerstore metrics #70

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Multistage image build for powerstore metrics #70

merged 1 commit into from
Jan 22, 2024

Conversation

panigs7
Copy link
Contributor

@panigs7 panigs7 commented Jan 18, 2024 •
edited
Loading

Description

Implement multistage image build for powerstore metrics

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1098

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have inspected the Grafana dashboards to verify the data is displayed properly
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Image build:
image

sanity test
image

image

@csmbot
Copy link
Collaborator

csmbot commented Jan 18, 2024

Can one of the admins verify this patch?

shefali-malhotra
shefali-malhotra approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@shefali-malhotra shefali-malhotra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitesh3108
Copy link
Contributor

e2e pass

2 similar comments
@rajendraindukuri
Copy link
Collaborator

e2e pass

@rajendraindukuri
Copy link
Collaborator

e2e pass

@rajendraindukuri
Copy link
Collaborator

skip e2e

@donatwork
Copy link
Contributor

e2e pass

@panigs7 panigs7 merged commit f292e9d into main Jan 22, 2024
8 checks passed
@anandrajak1 anandrajak1 deleted the multistage-docker-build-for-powerstore branch October 17, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shefali-malhotra shefali-malhotra shefali-malhotra approved these changes

@nitesh3108 nitesh3108 nitesh3108 approved these changes

@donatwork donatwork donatwork approved these changes

@atye atye Awaiting requested review from atye atye is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@anandrajak1 anandrajak1 Awaiting requested review from anandrajak1 anandrajak1 is a code owner

@bjiang27 bjiang27 Awaiting requested review from bjiang27 bjiang27 is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@EvgenyUglov EvgenyUglov Awaiting requested review from EvgenyUglov EvgenyUglov is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@HarishH-DELL HarishH-DELL Awaiting requested review from HarishH-DELL HarishH-DELL is a code owner

@harshaatdell harshaatdell Awaiting requested review from harshaatdell

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panigs7 @csmbot @nitesh3108 @rajendraindukuri @donatwork @shefali-malhotra