Fix issue with stripped vmlinux and re-introduce Gentoo tests #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmlinux is not guaranteed to contain a .comment section, if it is missing then readelf complains. To prevent this complaint from interfering with the tests redirect stderr through the pipe as well for this check. This also silences some useless noise at runtime. Functionally this changes nothing, both before and after this change the lack of a .comment section would cause the code to fall back to the second .config based check. This issue was discovered on Gentoo, where the package manager will strip most installed files to save space unless instructed not to by the user. Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Should be faster now due to making better use of the binhost, setting MAKEOPTS for parallelisation, using the parallel-install feature, and using a faster repository syncing method. Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Merged
|
Perfect, than you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readelfif, for example, the.commentsection is missing fromvmlinux. If readelf fails then we should always just continue with the second.configbased check.[EDIT] Gentoo tests now complete successfully after 4 minutes, I'd say that is quite fast.