Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDS Unit Test #159

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Add SDS Unit Test #159

merged 3 commits into from
Dec 13, 2024

Conversation

falfaroc
Copy link
Collaborator

@falfaroc falfaroc commented Dec 13, 2024

Description

Add SDS unit tests to coverage over 90% in the sds.go.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Increase SDS unit tests past the threshold.

Current Coverage:

PASS
coverage: 56.8% of statements
ok      github.com/dell/goscaleio       0.203s  coverage: 56.8% of statements

image

@falfaroc falfaroc force-pushed the usr/falfaroc/sds-unit-test branch from fe3701e to 66ae6a6 Compare December 13, 2024 20:17
@falfaroc falfaroc merged commit 77d4eec into main Dec 13, 2024
5 of 6 checks passed
@falfaroc falfaroc deleted the usr/falfaroc/sds-unit-test branch December 13, 2024 20:19
@falfaroc falfaroc restored the usr/falfaroc/sds-unit-test branch December 13, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants