Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fault set changes added #87

Merged
merged 5 commits into from
Oct 26, 2023
Merged

fault set changes added #87

merged 5 commits into from
Oct 26, 2023

Conversation

AnikaAgiwal2711
Copy link
Collaborator

@AnikaAgiwal2711 AnikaAgiwal2711 commented Oct 23, 2023 •
edited
Loading

Description

This PR contains adding new functionalities for fault set like : creating , modifying, deleting and reading a fault set

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

Created a test file and added the scenarios there.
image

Unit test
image

  • Test A
  • Test B

shenda1
shenda1 reviewed Oct 23, 2023
View reviewed changes
fault_set.go Outdated Show resolved Hide resolved
shenda1
shenda1 reviewed Oct 25, 2023
View reviewed changes
fault_set.go Outdated Show resolved Hide resolved
@shenda1 shenda1 requested review from suryagupta4 and adarsh-dell and removed request for khareRajshree October 25, 2023 05:32
adarsh-dell
adarsh-dell reviewed Oct 25, 2023
View reviewed changes
fault_set.go Outdated Show resolved Hide resolved
VamsiSiddu-7
VamsiSiddu-7 suggested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@VamsiSiddu-7 VamsiSiddu-7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me. Can you please add unit tests

@AnikaAgiwal2711
Copy link
Collaborator Author

Changes looks good to me. Can you please add unit tests

Sure Vamsi. Let me add

@AnikaAgiwal2711
Copy link
Collaborator Author

added the unit test

@AnikaAgiwal2711 AnikaAgiwal2711 merged commit d75ef34 into main Oct 26, 2023
1 check failed
@shanmydell shanmydell deleted the fault-set branch October 16, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VamsiSiddu-7 VamsiSiddu-7 VamsiSiddu-7 approved these changes

@shenda1 shenda1 shenda1 approved these changes

@KshitijaKakde KshitijaKakde Awaiting requested review from KshitijaKakde KshitijaKakde is a code owner

@suryagupta4 suryagupta4 Awaiting requested review from suryagupta4 suryagupta4 is a code owner

@adarsh-dell adarsh-dell Awaiting requested review from adarsh-dell adarsh-dell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnikaAgiwal2711 @shenda1 @VamsiSiddu-7 @adarsh-dell