Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated DrvCfgQuerySystems to fetch systems using drv_cfg #89

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Updated DrvCfgQuerySystems to fetch systems using drv_cfg #89

merged 3 commits into from
Nov 17, 2023

Conversation

suryagupta4
Copy link
Contributor

@suryagupta4 suryagupta4 commented Nov 17, 2023 •
edited
Loading

Description

Modified DrvCfgQuerySystems to query the mdm's using drv_cfg to fetch all the systems configured. SDC Rename depends on the output received from this function such that it can do renaming for all the systems.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1020

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • make unit-test
    image

  • make int-test
    image

@suryagupta4 suryagupta4 marked this pull request as ready for review November 17, 2023 11:01
adarsh-dell
adarsh-dell approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@adarsh-dell adarsh-dell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AkshaySainiDell
AkshaySainiDell approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@AkshaySainiDell AkshaySainiDell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@suryagupta4 suryagupta4 changed the title Sdc rename fix Updated DrvCfgQuerySystems to fetch systems using drv_cfg Nov 17, 2023
@suryagupta4 suryagupta4 merged commit 9981200 into main Nov 17, 2023
1 check failed
@shanmydell shanmydell deleted the sdc-rename-fix branch October 16, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adarsh-dell adarsh-dell adarsh-dell approved these changes

@AkshaySainiDell AkshaySainiDell AkshaySainiDell approved these changes

@bharathsreekanth bharathsreekanth bharathsreekanth approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suryagupta4 @bharathsreekanth @AkshaySainiDell @adarsh-dell