Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sdcIPs parameter #90

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Added sdcIPs parameter #90

merged 1 commit into from
Nov 30, 2023

Conversation

suryagupta4
Copy link
Contributor

Description

Added sdcIPs parameter in the Sdc struct such that when worker host have multiple ip's, all of them can be added to NFS export when ControllerPublishVolume call will happen.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1011

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Ran make unit-test
    image

  • Installed the driver, sdcIPs parameter was getting populated and used by the ControllerPublishVolume call.

@suryagupta4 suryagupta4 merged commit 0021dad into main Nov 30, 2023
1 check failed
@shanmydell shanmydell deleted the external-access branch October 16, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants