Skip to content

Commit

Permalink
Merge pull request #2218 from glimchb/patch-2
Browse files Browse the repository at this point in the history
ci(lint): adding docker linter
  • Loading branch information
sujit-jadhav authored Jan 14, 2024
2 parents e98f14f + 6ee9f30 commit 9f00d11
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/ansible-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@ jobs:
- name: Run tests
run: docker run -v $PWD:/workdir ghcr.io/igorshubovych/markdownlint-cli:latest --disable=MD013 "**/*.md" || true

docker-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: hadolint/hadolint-action@v3.1.0
with:
recursive: false
ignore: DL3041,DL3059,DL3013

ansible-lint:

runs-on: ubuntu-latest
Expand Down
9 changes: 5 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM rockylinux:8.8
WORKDIR /app

# why this is not part of prereq.sh ?
RUN dnf install -y python38 iproute
RUN dnf install -y python38 iproute && dnf clean all

# prereq
RUN echo "SELINUX=disabled" > /etc/selinux/config
Expand All @@ -19,14 +19,15 @@ RUN dnf install -y \
net-snmp \
net-snmp-utils \
sshpass \
python3-pexpect
python3-pexpect \
&& dnf clean all

# why above RPMs are not enough ?
RUN python3 -m pip install netaddr pexpect
RUN python3 -m pip install --no-cache-dir netaddr pexpect

# why this is not part of prereq.sh ?
# see telemetry/roles/omnia_telemetry_cp/tasks/python_package_installation.yml
RUN python3 -m pip install pyinstaller psutil
RUN python3 -m pip install --no-cache-dir pyinstaller psutil

ENTRYPOINT ["ansible-playbook"]
CMD ["prepare_cp.yml", "-vv"]

0 comments on commit 9f00d11

Please sign in to comment.