Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(lint): adding docker linter #2218

Merged
merged 2 commits into from
Jan 14, 2024
Merged

ci(lint): adding docker linter #2218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c33ff8c
ci(lint): adding docker linter
glimchb Jan 12, 2024
6ee9f30
Merge branch 'devel' into patch-2
sujit-jadhav Jan 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ansible-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,15 @@ jobs:
- name: Run tests
run: docker run -v $PWD:/workdir ghcr.io/igorshubovych/markdownlint-cli:latest --disable=MD013 "**/*.md" || true

docker-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: hadolint/hadolint-action@v3.1.0
with:
recursive: false
ignore: DL3041,DL3059,DL3013

ansible-lint:

runs-on: ubuntu-latest
Expand Down
9 changes: 5 additions & 4 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ FROM rockylinux:8.8
WORKDIR /app

# why this is not part of prereq.sh ?
RUN dnf install -y python38 iproute
RUN dnf install -y python38 iproute && dnf clean all

# prereq
RUN echo "SELINUX=disabled" > /etc/selinux/config
Expand All @@ -19,14 +19,15 @@ RUN dnf install -y \
net-snmp \
net-snmp-utils \
sshpass \
python3-pexpect
python3-pexpect \
&& dnf clean all

# why above RPMs are not enough ?
RUN python3 -m pip install netaddr pexpect
RUN python3 -m pip install --no-cache-dir netaddr pexpect

# why this is not part of prereq.sh ?
# see telemetry/roles/omnia_telemetry_cp/tasks/python_package_installation.yml
RUN python3 -m pip install pyinstaller psutil
RUN python3 -m pip install --no-cache-dir pyinstaller psutil

ENTRYPOINT ["ansible-playbook"]
CMD ["prepare_cp.yml", "-vv"]