Adding validators to user and usergroup datasources (#255)

* Adding validators to user and usergroup datasources * Fixing S3 bucket ds tests
dell · Nov 20, 2024 · 14447c2 · 14447c2
1 parent 1aced9d
commit 14447c2
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 7 deletions.
diff --git a/powerscale/provider/s3_bucket_datasource_test.go b/powerscale/provider/s3_bucket_datasource_test.go
@@ -44,7 +44,7 @@ func TestAccS3BucketDatasource(t *testing.T) {
 	})
 }
 
-func TestAccS3BucketsourceGetAll(t *testing.T) {
+func TestAccS3BucketDatasourceGetAll(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
 		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
@@ -157,30 +157,33 @@ resource "powerscale_s3_bucket" "bucket_resource_test" {
 	}]
 }
 
-data "powerscale_s3_bucket" "bucket_datasource_test_all" {}
+data "powerscale_s3_bucket" "bucket_datasource_test_all" {
+  	depends_on = [
+    	powerscale_s3_bucket.bucket_resource_test
+  	]
+}
 `, bucketName, bucketName)
 
 var S3BucketDatasourceConfig = fmt.Sprintf(`
 resource "powerscale_s3_bucket" "bucket_resource_test" {
 	name = "%s"
 	path = "/ifs/%s"
 	create_path = true
+	zone  = "System"
 	acl = [{
 		grantee = {
 			name = "Everyone"
 			type = "wellknown"
 		}
 		permission = "FULL_CONTROL"
 	}]
+		
 }
 
 data "powerscale_s3_bucket" "bucket_datasource_test" {
 	filter {
 		zone  = "System"
-		owner = "root"
+		owner = powerscale_s3_bucket.bucket_resource_test.owner
 	}
-  	depends_on = [
-    	powerscale_s3_bucket.bucket_resource_test
-  	]
 }
 `, bucketName, bucketName)
diff --git a/powerscale/provider/user_data_source.go b/powerscale/provider/user_data_source.go
@@ -26,6 +26,7 @@ import (
 	"terraform-provider-powerscale/powerscale/helper"
 	"terraform-provider-powerscale/powerscale/models"
 
+	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
 	"github.com/hashicorp/terraform-plugin-framework/datasource"
 	"github.com/hashicorp/terraform-plugin-framework/datasource/schema"
@@ -261,6 +262,9 @@ func (d *UserDataSource) Schema(ctx context.Context, req datasource.SchemaReques
 								},
 							},
 						},
+						Validators: []validator.List{
+							listvalidator.SizeAtLeast(1),
+						},
 					},
 					"name_prefix": schema.StringAttribute{
 						Optional:            true,

diff --git a/powerscale/provider/user_group_data_source.go b/powerscale/provider/user_group_data_source.go
@@ -25,6 +25,7 @@ import (
 	"terraform-provider-powerscale/powerscale/helper"
 	"terraform-provider-powerscale/powerscale/models"
 
+	"github.com/hashicorp/terraform-plugin-framework-validators/listvalidator"
 	"github.com/hashicorp/terraform-plugin-framework-validators/stringvalidator"
 	"github.com/hashicorp/terraform-plugin-framework/datasource"
 	"github.com/hashicorp/terraform-plugin-framework/datasource/schema"
@@ -184,6 +185,9 @@ func (d *UserGroupDataSource) Schema(ctx context.Context, req datasource.SchemaR
 								},
 							},
 						},
+						Validators: []validator.List{
+							listvalidator.SizeAtLeast(1),
+						},
 					},
 					"name_prefix": schema.StringAttribute{
 						Optional:            true,

diff --git a/powerscale/provider/user_group_datasource_test.go b/powerscale/provider/user_group_datasource_test.go
@@ -113,7 +113,6 @@ func TestAccUserGroupDataSourceAll(t *testing.T) {
 var userGroupFilterDataSourceConfig = `
 data "powerscale_user_group" "test" {
   filter {
-	names = []
 	cached = false
 	# name_prefix = ""
 	# domain = ""