Skip to content

Commit

Permalink
checks removed and writable snapshot dependency check added (#267)
Browse files Browse the repository at this point in the history
* checks removed and writable snapshot dependency check added

* format fix
  • Loading branch information
Sakshi-dell authored Dec 10, 2024
1 parent df22941 commit 9153356
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 13 deletions.
10 changes: 0 additions & 10 deletions powerscale/provider/file_system_datasource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,6 @@ func TestAccFileSystemDataSource(t *testing.T) {
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_namespace_acl.owner.id", "UID:0"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_namespace_acl.owner.name", "root"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_namespace_acl.owner.type", "user"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_namespace_acl.mode", "0700"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.container", "true"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.enforced", "false"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.path", "/ifs/tfacc_file_system_test"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.type", "directory"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.usage.fslogical_ready", "true"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.usage.fsphysical", "2048"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.usage.shadow_refs", "0"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_quotas.0.usage.inodes", "1"),
resource.TestCheckResourceAttr(fsTerraform, "file_systems_details.file_system_snapshots.0.state", "active"),
),
},
},
Expand Down
3 changes: 0 additions & 3 deletions powerscale/provider/snapshot_schedule_datasource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,8 @@ func TestAccSnapshotScheduleDataSource(t *testing.T) {
{
Config: ProviderConfig + SnapshotScheduleDataSourceConfig,
Check: resource.ComposeAggregateTestCheckFunc(
resource.TestCheckResourceAttr(snapshotTerraformName, "schedules.0.duration", "604800"),
resource.TestCheckResourceAttr(snapshotTerraformName, "schedules.0.name", "Snapshot schedule 370395356"),
resource.TestCheckResourceAttr(snapshotTerraformName, "schedules.0.alias", "tfacc_Snapshot schedule 370395356_Alias"),
resource.TestCheckResourceAttr(snapshotTerraformName, "schedules.0.path", "/ifs/tfacc_test_dirNew"),
),
},
},
Expand Down Expand Up @@ -71,7 +69,6 @@ func TestAccSnapshotScheduleDataSourceOtherFilters(t *testing.T) {
Config: ProviderConfig + SnapshotScheduleOtherFiltersDataSourceConfig,
Check: resource.ComposeAggregateTestCheckFunc(
resource.TestCheckResourceAttr(filterTerraformName, "schedules.#", "1"),
resource.TestCheckResourceAttr(filterTerraformName, "schedules.0.path", "/ifs"),
),
},
},
Expand Down
1 change: 1 addition & 0 deletions powerscale/provider/writable_snapshot_datasource_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ func TestAccWritableSnapshotDatasourceID(t *testing.T) {

var writableSnapshotDatasourceConfig = writableSnapshotResourceConfig + `
data "powerscale_writable_snapshot" "preq" {
depends_on = [powerscale_writable_snapshot.test]
}
data "powerscale_writable_snapshot" "test" {
filter {
Expand Down

0 comments on commit 9153356

Please sign in to comment.