Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added validation for invalid id #260

Merged
merged 7 commits into from
Nov 20, 2024
Merged

added validation for invalid id #260

merged 7 commits into from
Nov 20, 2024

Conversation

AnikaAgiwal2711
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@AnikaAgiwal2711
Copy link
Contributor Author

run e2e test TestAccReplicationReportsDataSource

@AnikaAgiwal2711
Copy link
Contributor Author

run e2e test ReplicationReportsDataSource

@Krunal-Thakkar Krunal-Thakkar self-requested a review November 20, 2024 10:43
@AnikaAgiwal2711
Copy link
Contributor Author

run e2e test ReplicationReportsDataSource

@AnikaAgiwal2711 AnikaAgiwal2711 merged commit 42bf570 into main Nov 20, 2024
7 checks passed
@AnikaAgiwal2711 AnikaAgiwal2711 deleted the fix-global-settings-at branch November 20, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akshay-sripriya akshay-sripriya akshay-sripriya approved these changes

@Krunal-Thakkar Krunal-Thakkar Krunal-Thakkar approved these changes

@Sakshi-dell Sakshi-dell Sakshi-dell approved these changes

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

@vangork vangork Awaiting requested review from vangork vangork is a code owner

@sapana05 sapana05 Awaiting requested review from sapana05 sapana05 is a code owner

@MangirishK MangirishK Awaiting requested review from MangirishK MangirishK is a code owner

@rounak-adhikary rounak-adhikary Awaiting requested review from rounak-adhikary rounak-adhikary is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnikaAgiwal2711 @Sakshi-dell @Krunal-Thakkar @akshay-sripriya