Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added validation for network pool/rule ds #262

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

Krishnan-Priyanshu
Copy link
Contributor

Description

A few sentences describing the overall goals of the pull request's commits.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME
OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@AnikaAgiwal2711
Copy link
Contributor

image

@AnikaAgiwal2711
Copy link
Contributor

image

@Krishnan-Priyanshu
Copy link
Contributor Author

e2e run test RuleDatasource

@Krunal-Thakkar
Copy link
Contributor

run e2e test RuleDatasource,NetworkPoolDataSource

@shenda1 shenda1 merged commit 91e3957 into main Nov 21, 2024
7 checks passed
@shenda1 shenda1 deleted the usr/priyanshu/validation_fix branch November 21, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants