Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove at hardcoding #268

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Remove at hardcoding #268

merged 2 commits into from
Dec 10, 2024

Conversation

shenda1
Copy link
Contributor

@shenda1 shenda1 commented Dec 10, 2024

Description

PR is raised to remove nfsv3_rrcoe_only flag from network pool data source.

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME

powerscale_networkpool

# Checklist:

- [x] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
- [x] I have verified that new and existing unit tests pass locally with my changes
- [x] I have not allowed coverage numbers to degenerate
- [x] I have maintained at least 80% code coverage
- [x] I have commented my code, particularly in hard-to-understand areas
- [x] I have made corresponding changes to the documentation
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have maintained backward compatibility


# How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

- [x] Unit tests
- [x] Acceptance tests

Signed-off-by: Shendge <akash.shendge@dell.com>
Signed-off-by: Shendge <akash.shendge@dell.com>
@shenda1
Copy link
Contributor Author

shenda1 commented Dec 10, 2024

run e2e test NetworkPoolDataSource

@shenda1 shenda1 merged commit 38bc2f5 into main Dec 10, 2024
7 checks passed
@shenda1 shenda1 deleted the remove_at_hardcoding branch December 10, 2024 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants