Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prechecks for create and update params for AD #33

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Add prechecks for create and update params for AD #33

merged 1 commit into from
Sep 5, 2023

Conversation

RayLiu7
Copy link
Contributor

@RayLiu7 RayLiu7 commented Sep 1, 2023

Description

Add prechecks for create and update params to deal with the situation where fields are only allowed while creating not updating and vice versa
Use plan to update local record instead of state

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME

Active Directory

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Sep 1, 2023

run e2e test

@RayLiu7 RayLiu7 changed the title Add prechecks for create and update params Add prechecks for create and update params for AD Sep 4, 2023
NavisJ
NavisJ previously approved these changes Sep 4, 2023
View reviewed changes
taohe1012
taohe1012 previously approved these changes Sep 4, 2023
View reviewed changes
powerscale/provider/ads_provider_resource.go Outdated Show resolved Hide resolved
@RayLiu7 RayLiu7 dismissed stale reviews from taohe1012 and NavisJ via 51df551 September 4, 2023 06:11
@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Sep 4, 2023

run e2e test

baoy1
baoy1 approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@baoy1 baoy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd better have only one commit in the PR. Please remove the "merge" commit.

@RayLiu7 RayLiu7 force-pushed the bugfix-ad-precheck branch 2 times, most recently from 6bc9137 to fde0732 Compare September 5, 2023 01:51
@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Sep 5, 2023

run e2e test

@RayLiu7
Add prechecks for create and update params
364145d 
Use plan to update local record instead of state
@RayLiu7
Copy link
Contributor Author

RayLiu7 commented Sep 5, 2023

run e2e test

@RayLiu7 RayLiu7 merged commit 0b06544 into main Sep 5, 2023
6 checks passed
@RayLiu7 RayLiu7 deleted the bugfix-ad-precheck branch September 5, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baoy1 baoy1 baoy1 approved these changes

@taohe1012 taohe1012 taohe1012 approved these changes

@NavisJ NavisJ NavisJ left review comments

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@doriac11 doriac11 Awaiting requested review from doriac11 doriac11 is a code owner

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RayLiu7 @taohe1012 @baoy1 @NavisJ