Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File system validate owner/group information #37

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

nikitajoshi1
Copy link
Contributor

@nikitajoshi1 nikitajoshi1 commented Sep 5, 2023

Description

Validate owner/group information for File System Resource

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
RESOURCE OR DATASOURCE NAME

File System Resource

OUTPUT

FS_resource

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@nikitajoshi1
Copy link
Contributor Author

run e2e test

@baoy1
Copy link
Contributor

baoy1 commented Sep 6, 2023

@NavisJ , @P-Cao , @taohe1012 , @RayLiu7 , please check if helper.GetErrorString is properly used to expose the detail error returned by REST API.

@NavisJ
Copy link
Contributor

NavisJ commented Sep 6, 2023

@NavisJ , @P-Cao , @taohe1012 , @RayLiu7 , please check if helper.GetErrorString is properly used to expose the detail error returned by REST API.

Yes. OpenAPI client error needs extra handling for correct display.
And also on line 376

powerscale/helper/file_system_helper.go Outdated Show resolved Hide resolved
powerscale/helper/file_system_helper.go Outdated Show resolved Hide resolved
@nikitajoshi1 nikitajoshi1 force-pushed the File-System-User-Update branch from afb5211 to 656a792 Compare September 7, 2023 19:33
@nikitajoshi1
Copy link
Contributor Author

run e2e test

powerscale/helper/file_system_helper.go Outdated Show resolved Hide resolved
@nikitajoshi1 nikitajoshi1 force-pushed the File-System-User-Update branch from 656a792 to 20318fe Compare September 8, 2023 17:12
@nikitajoshi1
Copy link
Contributor Author

run e2e test

@nikitajoshi1 nikitajoshi1 merged commit 92955f9 into main Sep 8, 2023
6 checks passed
@nikitajoshi1 nikitajoshi1 deleted the File-System-User-Update branch September 8, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants