Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add credits for dependency license #45

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Add credits for dependency license #45

merged 1 commit into from
Sep 13, 2023

Conversation

P-Cao
Copy link
Contributor

@P-Cao P-Cao commented Sep 12, 2023

Description

add ATTRIBUTION.md

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
RESOURCE OR DATASOURCE NAME
OUTPUT
ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@P-Cao
Copy link
Contributor Author

P-Cao commented Sep 12, 2023

run e2e test

@P-Cao P-Cao marked this pull request as ready for review September 12, 2023 07:36
@P-Cao P-Cao force-pushed the feature-license-attribution branch from 127113f to c6b8cab Compare September 12, 2023 08:22
@P-Cao
Copy link
Contributor Author

P-Cao commented Sep 12, 2023

run e2e test

1 similar comment
@P-Cao
Copy link
Contributor Author

P-Cao commented Sep 12, 2023

run e2e test

@P-Cao P-Cao force-pushed the feature-license-attribution branch from c6b8cab to 0e9c765 Compare September 13, 2023 01:26
@P-Cao
Copy link
Contributor Author

P-Cao commented Sep 13, 2023

run e2e test

@P-Cao P-Cao force-pushed the feature-license-attribution branch from 0e9c765 to 1a5231b Compare September 13, 2023 01:37
@P-Cao
Copy link
Contributor Author

P-Cao commented Sep 13, 2023

run e2e test

@P-Cao P-Cao merged commit 58aac4e into main Sep 13, 2023
6 checks passed
@P-Cao P-Cao deleted the feature-license-attribution branch September 13, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriac11 doriac11 doriac11 approved these changes

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@NavisJ NavisJ Awaiting requested review from NavisJ

@nikitajoshi1 nikitajoshi1 Awaiting requested review from nikitajoshi1 nikitajoshi1 is a code owner

@shekhar-j shekhar-j Awaiting requested review from shekhar-j shekhar-j is a code owner

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@P-Cao @doriac11