Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileSystem FullPath Attribute #49

Merged
merged 2 commits into from
Sep 18, 2023
Merged

FileSystem FullPath Attribute #49

merged 2 commits into from
Sep 18, 2023

Conversation

doriac11
Copy link
Collaborator

Description

  • Add a parameter called full_path which includes the full path of the filesystem including the inital /. This initial / is removed from the ID for ease of use with the APIs but the full path can be useful by the terraform consumer.

ISSUE TYPE

  • Enhancement Pull Request
RESOURCE OR DATASOURCE NAME

Filesystem Resource

OUTPUT

image

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

- Add a parameter called `full_path` which includes the full path of the
  filesystem including the inital `/`. This initial `/` is removed from
  the ID for easie of use with the APIs but the full path can be useful
  by the terraform consumer.
@doriac11 doriac11 force-pushed the add-full-path-attribute branch from 3988a86 to 2c9f91e Compare September 15, 2023 12:23
@doriac11
Copy link
Collaborator Author

run e2e test

@doriac11
Copy link
Collaborator Author

I ran the tests locally with the fix provided for the mock server, not sure why it is still failing the e2e tests. It is not related to my changes here, it has to do with NFS datasource not returning empty from the mock server.

@forrestxia
Copy link
Collaborator

run e2e test

@forrestxia
Copy link
Collaborator

I ran the tests locally with the fix provided for the mock server, not sure why it is still failing the e2e tests. It is not related to my changes here, it has to do with NFS datasource not returning empty from the mock server.
@doriac11
@P-Cao has fixed the NFS case failures and that change has merged into main. Just kicked off a new PR check run after update your branch. thanks for quick fix and patience.

@forrestxia forrestxia merged commit eb706bf into main Sep 18, 2023
6 checks passed
@forrestxia forrestxia deleted the add-full-path-attribute branch September 18, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants