Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update File System Resource description to be consistent #53

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

nikitajoshi1
Copy link
Contributor

@nikitajoshi1 nikitajoshi1 commented Sep 19, 2023

Description

Update File System Resource description to be consistent

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Docs Pull Request
RESOURCE OR DATASOURCE NAME

File System Resource

OUTPUT

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@nikitajoshi1
Copy link
Contributor Author

run e2e test

@P-Cao
Copy link
Contributor

P-Cao commented Sep 20, 2023

Might need to update datasource description also: This datasource is used to query the existing <datasource_name> from PowerScale array. The information fetched from this datasource can be used for getting the details / for further processing in resource block.

@nikitajoshi1 nikitajoshi1 force-pushed the file-system-comment-update branch 2 times, most recently from bb9e08b to 48193ff Compare September 20, 2023 17:10
@nikitajoshi1
Copy link
Contributor Author

Might need to update datasource description also: This datasource is used to query the existing <datasource_name> from PowerScale array. The information fetched from this datasource can be used for getting the details / for further processing in resource block.

@P-Cao Updated. Thanks!

@nikitajoshi1 nikitajoshi1 force-pushed the file-system-comment-update branch from 48193ff to 8a338c0 Compare September 20, 2023 17:54
@nikitajoshi1
Copy link
Contributor Author

run e2e test

@forrestxia forrestxia merged commit 3b3e0d5 into main Sep 21, 2023
6 checks passed
@forrestxia forrestxia deleted the file-system-comment-update branch September 21, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants