Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snapshot DS (PowerScale 1.1) #60

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Add Snapshot DS (PowerScale 1.1) #60

merged 1 commit into from
Oct 4, 2023

Conversation

doriac11
Copy link
Collaborator

Description

  • Added the PowerScale Snapshot Datasource.
    (For the next release)

ISSUE TYPE

  • Feature Pull Request
RESOURCE OR DATASOURCE NAME

Snapshot Datasource

OUTPUT

image

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@doriac11 doriac11 force-pushed the snapshot-datasource branch 5 times, most recently from 26e68df to 1a12e18 Compare September 27, 2023 17:15
@doriac11
Copy link
Collaborator Author

run e2e test

@doriac11
Copy link
Collaborator Author

run e2e test

@doriac11
Add Snapshot DS
10f5ebd 
- Added the PowerScale Snapshot Datasource
@doriac11 doriac11 force-pushed the snapshot-datasource branch from d2ebbb3 to 10f5ebd Compare October 2, 2023 12:14
@doriac11
Copy link
Collaborator Author

doriac11 commented Oct 2, 2023

run e2e test

@doriac11 doriac11 merged commit 10f5ebd into main Oct 4, 2023
6 checks passed
@doriac11 doriac11 deleted the snapshot-datasource branch October 4, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikitajoshi1 nikitajoshi1 nikitajoshi1 approved these changes

@shekhar-j shekhar-j shekhar-j approved these changes

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@NavisJ NavisJ Awaiting requested review from NavisJ

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doriac11 @shekhar-j @nikitajoshi1