Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshot schedule datasource[Powerscale 1.1] #61

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Snapshot schedule datasource[Powerscale 1.1] #61

merged 1 commit into from
Oct 5, 2023

Conversation

nikitajoshi1
Copy link
Contributor

@nikitajoshi1 nikitajoshi1 commented Sep 27, 2023 •
edited
Loading

Description

  • Added Powerscale Snapshot Schedule Datasource and related tests

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #

ISSUE TYPE

  • Feature Pull Request
RESOURCE OR DATASOURCE NAME

Snapshot Schedule

OUTPUT

testSS
sscoverage
New test for other filters:
otherFilterTest

ADDITIONAL INFORMATION

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 80% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Unit tests
  • Acceptance tests

@nikitajoshi1 nikitajoshi1 force-pushed the snapshot-schedule-datasource branch 2 times, most recently from aa0ac97 to 292a81a Compare September 27, 2023 17:05
@doriac11
Copy link
Collaborator

Can you add the coverage amount to the ticket?

@nikitajoshi1 nikitajoshi1 force-pushed the snapshot-schedule-datasource branch 2 times, most recently from 929b445 to 7f72733 Compare September 27, 2023 19:08
@nikitajoshi1
Copy link
Contributor Author

Can you add the coverage amount to the ticket?

@doriac11 added coverage.

@nikitajoshi1 nikitajoshi1 force-pushed the snapshot-schedule-datasource branch from 7f72733 to 6d7431a Compare September 27, 2023 19:17
@nikitajoshi1 nikitajoshi1 force-pushed the snapshot-schedule-datasource branch 6 times, most recently from 454e6e4 to bfd3b92 Compare October 5, 2023 16:13
@nikitajoshi1
Copy link
Contributor Author

run e2e test

@nikitajoshi1 nikitajoshi1 force-pushed the snapshot-schedule-datasource branch from bfd3b92 to a82c192 Compare October 5, 2023 17:38
@nikitajoshi1
Snapshot schedule datasource
5bba1ac 
  - Added Powerscale Snapshot Schedule Datasource and related tests
@nikitajoshi1 nikitajoshi1 force-pushed the snapshot-schedule-datasource branch from a82c192 to 5bba1ac Compare October 5, 2023 18:45
@nikitajoshi1 nikitajoshi1 requested a review from shekhar-j October 5, 2023 18:50
@doriac11 doriac11 merged commit 5bba1ac into main Oct 5, 2023
6 checks passed
@doriac11 doriac11 deleted the snapshot-schedule-datasource branch October 5, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doriac11 doriac11 doriac11 approved these changes

@shekhar-j shekhar-j shekhar-j approved these changes

@shenda1 shenda1 Awaiting requested review from shenda1 shenda1 is a code owner

@forrestxia forrestxia Awaiting requested review from forrestxia forrestxia is a code owner

@baoy1 baoy1 Awaiting requested review from baoy1 baoy1 is a code owner

@taohe1012 taohe1012 Awaiting requested review from taohe1012 taohe1012 is a code owner

@P-Cao P-Cao Awaiting requested review from P-Cao P-Cao is a code owner

@tanh17 tanh17 Awaiting requested review from tanh17 tanh17 is a code owner

@NavisJ NavisJ Awaiting requested review from NavisJ

@RayLiu7 RayLiu7 Awaiting requested review from RayLiu7 RayLiu7 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikitajoshi1 @doriac11 @shekhar-j