Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DLPX-88488 profile is missing stack traces #16

Conversation

sumedhbala-delphix
Copy link
Contributor

@sumedhbala-delphix sumedhbala-delphix commented Nov 6, 2023

Clean cherrypick of b2e9c36
Testing: ab-pre-push passed

Ran the following to figure out number of entries on a 4 core system
without the change:
"""
delphix@ip-10-110-214-21:/var/delphix/server/log/stats$ grep -v '^-' profile_3600.log | grep -o ' [0-9]$' | paste -s -d+ - | bc
721214
"""
721214/(60
60499) = ~50% hit rate

with the change:
"""
delphix@ip-10-110-238-208:/var/delphix/server/log/stats$ grep -v '2023-11-01' profile_3600.log | grep -o ' [0-9]$' | paste -s -d+ - | bc
1237787
"""
1237787/(60
60499) = ~80% hit rate

I doubled the default hash to 81920 and we got to 83% hit rate, does not seem like we gain too much with increasing the hash size.

@sumedhbala-delphix sumedhbala-delphix force-pushed the dlpx/pr/sumedhbala-delphix/38c83bee-76f9-4c73-b85c-15eb79f3de53 branch from 2e6ff3b to b2e9c36 Compare November 6, 2023 18:46
@sumedhbala-delphix sumedhbala-delphix marked this pull request as ready for review November 6, 2023 18:57
@sumedhbala-delphix sumedhbala-delphix force-pushed the dlpx/pr/sumedhbala-delphix/38c83bee-76f9-4c73-b85c-15eb79f3de53 branch from b2e9c36 to e7e3701 Compare November 6, 2023 22:51
@sumedhbala-delphix sumedhbala-delphix force-pushed the dlpx/pr/sumedhbala-delphix/38c83bee-76f9-4c73-b85c-15eb79f3de53 branch from e7e3701 to 588a87d Compare November 6, 2023 22:51
@sumedhbala-delphix sumedhbala-delphix changed the title tools/profile: Allow to increment hash storage size to aviod missing keys DLPX-88488 profile is missing stack traces Nov 6, 2023
@sumedhbala-delphix sumedhbala-delphix merged commit f1d8983 into develop Nov 7, 2023
1 of 3 checks passed
@sumedhbala-delphix sumedhbala-delphix deleted the dlpx/pr/sumedhbala-delphix/38c83bee-76f9-4c73-b85c-15eb79f3de53 branch November 7, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants