DLPX-88488 profile is missing stack traces #16
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean cherrypick of b2e9c36
Testing: ab-pre-push passed
Ran the following to figure out number of entries on a 4 core system
without the change:
"""
delphix@ip-10-110-214-21:/var/delphix/server/log/stats$ grep -v '^-' profile_3600.log | grep -o ' [0-9]$' | paste -s -d+ - | bc
721214
"""
721214/(6060499) = ~50% hit rate
with the change:
"""
delphix@ip-10-110-238-208:/var/delphix/server/log/stats$ grep -v '2023-11-01' profile_3600.log | grep -o ' [0-9]$' | paste -s -d+ - | bc
1237787
"""
1237787/(6060499) = ~80% hit rate
I doubled the default hash to 81920 and we got to 83% hit rate, does not seem like we gain too much with increasing the hash size.