[Kernel] Add an end2end prototype of InCommitTimestamp in kernel #3262
+1,167
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkorukanti
reviewed
Jun 12, 2024
There was a problem hiding this comment.
Thank @EstherBear for making this PR. Looks great!
I think now we can divide them into multiple smaller PRs. First PR can be an API on TxnBuilder to set the table properties.
kernel/kernel-api/src/main/java/io/delta/kernel/exceptions/MissingCommitInfoException.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/exceptions/MissingCommitInfoException.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/TransactionBuilderImpl.java
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/ConflictChecker.java
Outdated
Show resolved
Hide resolved
kernel/kernel-defaults/src/test/scala/io/delta/kernel/defaults/InCommitTimestampSuite.scala
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/util/SystemClock.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/exceptions/MissingCommitTimestampException.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/DeltaHistoryManager.java
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/TableConfig.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/TableConfig.java
Outdated
Show resolved
Hide resolved
kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/ConflictChecker.java
Outdated
Show resolved
Hide resolved
EstherBear
force-pushed
the
kernel-ict-prototype
branch
2 times, most recently
from
db3443b
to
077555d
Compare
EstherBear
force-pushed
the
kernel-ict-prototype
branch
from
077555d
to
fa8cd35
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an end2end prototype of InCommitTimestamp in kernel.
Which Delta project/connector is this regarding?
Description
How was this patch tested?
Does this PR introduce any user-facing changes?