[Spark] Extend coordinated commit changes to other suites #3305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // a few properties will be automatically populated, and this method will take care of it. | ||
| protected def getPropertiesJson(extraProperty: Option[Map[String, String]] = None): String = { | ||
| val coordinatedCommitsProperty = if (coordinatedCommitsEnabledInTests) { | ||
| getCoordinatedCommitsDefaultProperties() |
There was a problem hiding this comment.
Why is this call-site needs withICT as false while the other one in DescribeDeltaDetailSuite.scala passes it as true?
There was a problem hiding this comment.
DESCRIBE DETAIL returns ICT information as well, but HISTORY doesn't. The helper just evolves to cover both cases.
junlee-db
force-pushed
the
junlee-db/coordinated_commit_units
branch
from
ffbf71c
to
ae0582a
Compare
junlee-db
force-pushed
the
junlee-db/coordinated_commit_units
branch
from
ae0582a
to
f59d7a1
Compare
prakharjain09
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Extends various existing Delta suite with coordinated commits. This helps to add more coverage with coordinated commit changes.
How was this patch tested?
This is test PR.
Does this PR introduce any user-facing changes?
No