[Spark] Use location as the table path #3330
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
changed the title
Fokko
changed the title
Fokko
commented
Jul 2, 2024
| @@ -123,13 +122,15 @@ class ConvertToIcebergSuite extends QueryTest with Eventually { | |||
| withDefaultTablePropsInSQLConf { | |||
| deltaSpark.range(10).write.format("delta") | |||
| .option("path", testTablePath) | |||
| .option("delta.enableIcebergCompatV2", "true") | |||
There was a problem hiding this comment.
I was unable to let the tests pass without this property.
There was a problem hiding this comment.
Same here! cc @lzlfred @scottsand-db @harperjiang
Fokko
force-pushed
the
fd-allow-setting-the-path
branch
4 times, most recently
from
84f821e
to
2c6775c
Compare
Fokko
force-pushed
the
fd-allow-setting-the-path
branch
from
2c6775c
to
c2f7273
Compare
4 tasks
amogh-jahagirdar
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
This will include the table path, to avoid defaulting to the path that Hive suggests.
How was this patch tested?
Does this PR introduce any user-facing changes?