[Spark] Remove dropped columns when running REORG PURGE #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @johanl-db, could you help review this pr? Thanks! |
johanl-db
reviewed
Jul 15, 2024
spark/src/main/scala/org/apache/spark/sql/delta/commands/ReorgTableHelper.scala
Outdated
Show resolved
Hide resolved
spark/src/test/scala/org/apache/spark/sql/delta/optimize/DeltaReorgSuite.scala
Show resolved
Hide resolved
… columns; update fileHasDroppedColumns to fileHasExtraColumns
johanl-db
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
According to #3228, we add the support to also find and remove dropped columns when running
REORG PURGE.Close #3228.
How was this patch tested?
Through unit test in
DeltaReorgSuite.scala.Does this PR introduce any user-facing changes?
No.