Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed sdk docs and refer links #1632

Merged
merged 4 commits into from
Oct 9, 2024
Merged

Removed sdk docs and refer links #1632

merged 4 commits into from
Oct 9, 2024

Conversation

Shellyber
Copy link
Contributor

Status

Ready/

Related Issues

fixes: CIAC-11879

Description

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1632-n477aen6.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

ShahafBenYakir
ShahafBenYakir reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@ShahafBenYakir ShahafBenYakir left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look ok to me.
Will let @samuelFain to give the final approval here.

docs/concepts/dev-setup.md Show resolved Hide resolved
@shmuel44
Copy link
Contributor

shmuel44 commented Oct 7, 2024

Look ok to me. Will let @shmuel44 to give the final approval here.

FYI @samuelFain (Shmuel proxy 😄 )

@xsoar-bot
Copy link

Preview Site Available

Congratulations! The automatic build has completed successfully.
A preview site is available at: https://xsoar-pan-dev--pull-request-1632-n477aen6.web.app

Important: Make sure to inspect your changes at the preview site.

Detected modified urls:

samuelFain
samuelFain approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@samuelFain samuelFain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Shellyber Shellyber merged commit 136c0bb into master Oct 9, 2024
8 checks passed
@Shellyber Shellyber deleted the demisto-sdk-changes branch October 9, 2024 08:00
@xsoar-bot
Copy link

Production Site Updated

Congratulations! The automatic build has completed successfully.
The production site of our docs has been updated. You can view it at: https://xsoar.pan.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dorschw dorschw dorschw left review comments

@ShahafBenYakir ShahafBenYakir ShahafBenYakir left review comments

@samuelFain samuelFain samuelFain approved these changes

@dantavori dantavori Awaiting requested review from dantavori

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Shellyber @xsoar-bot @shmuel44 @ShahafBenYakir @samuelFain @dorschw