GitHub Action to Compare Dependencies #29728
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.6.0.103670 Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.6.0.103685 Docker Metadata
|
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.6.0.103850 Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.6.0.103856 Docker Metadata
|
Docker Image Ready - DevDocker automatic build at CircleCI has deployed your docker image: devdemisto/py3-native:8.7.0.108164 Docker Metadata
|
Co-authored-by: dorschw <81086590+dorschw@users.noreply.github.com>
…ckerfiles into sk_github_sync_native
dorschw
reviewed
Aug 21, 2024
| def __str__(self) -> str: | ||
| return ( | ||
| f"{self.dependency} is {self.in_image or 'missing'} in {self.image}, " | ||
| f"but {self.in_reference or 'missing'} in the {self.reference_image} image. " |
There was a problem hiding this comment.
Suggested change
| f"but {self.in_reference or 'missing'} in the {self.reference_image} image. " | |
| f"but {self.in_reference or 'missing'} in {self.reference_image}. " |
Comment on lines
+60
to
+63
| if path.suffix == PIPFILE: | ||
| return lower_dict_keys(_parse_pipfile(path)) | ||
|
|
||
| return lower_dict_keys(_parse_pyproject(path)) |
There was a problem hiding this comment.
best to have an
elif : ...
else: raise RuntimeErrorfor safety
Comment on lines
+102
to
+111
| """Compares the dependency constraints between different images and reports discrepancies. | ||
|
|
||
| This function compares the dependencies of the following images: | ||
| - `py3-tools` | ||
| - `py3-tools-ubi` | ||
| - `native` | ||
|
|
||
| against the dependencies of the images listed in `images_contained_in_native`. | ||
|
|
||
| Additionally, it compares the dependencies of `py3-tools` against `py3-tools-ubi`. |
There was a problem hiding this comment.
split the docs between the two methods, this one shouldn't document the others
| for dependency in sorted( | ||
| constraint_keys.difference(native_constraint_keys) | ||
| ) | ||
| discrepancies.extend(compare_with_native(image, native_constraints)) |
There was a problem hiding this comment.
this should be in compare_with_native
| return int(bool(discrepancies)) | ||
|
|
||
|
|
||
| def compare_with_native(image: str, native_constraints: dict) -> list[Discrepancy]: |
There was a problem hiding this comment.
rename to find_native_discrepancies
| return discrepancies | ||
|
|
||
|
|
||
| def compare_py3_tools_with_ubi( |
There was a problem hiding this comment.
Suggested change
| def compare_py3_tools_with_ubi( | |
| def find_ubi_discrepancies( |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you'd like to keep it open, please leave a comment with the status of the PR. Thank you for your contribution! |
|
This pull request has been automatically closed because there has been no activity for 21 days. Please feel free to reopen it (or open a new one) if the proposed change is still appropriate. Thank you for your contribution! |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you'd like to keep it open, please leave a comment with the status of the PR. Thank you for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Related: link to the issue
Description
Added a GitHub action to check if there is a difference between dependencies of the native Docker image and all the other images that are supported by the native image.