Detect correct accessibility for generated record properties

dendrodocs · Aug 30, 2024 · db06481 · db06481
1 parent 17eaf6f
commit db06481
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 0 deletions.
diff --git a/src/DendroDocs.Tool/Analyzers/SourceAnalyzer.cs b/src/DendroDocs.Tool/Analyzers/SourceAnalyzer.cs
@@ -376,6 +376,15 @@ private PropertyDescription CreatePropertyDescription(IPropertySymbol property)
     {
         var modifiers = property.IsReadOnly ? Modifier.Readonly : 0;
 
+        modifiers |= property.DeclaredAccessibility switch
+        {
+            Accessibility.Public => Modifier.Public,
+            Accessibility.Protected => Modifier.Protected,
+            Accessibility.Internal => Modifier.Internal,
+            Accessibility.Private => Modifier.Private,
+            _ => 0
+        };
+
         var propertyDescription = new PropertyDescription(property.Type.ToDisplayString(), property.Name)
         {
             Modifiers = modifiers

diff --git a/tests/DendroDocs.Tool.Tests/RecordDeclarationTests.cs b/tests/DendroDocs.Tool.Tests/RecordDeclarationTests.cs
@@ -105,4 +105,44 @@ internal record struct NestedC {};
         // Assert
         types[1].Modifiers.Should().HaveFlag(modifier);
     }
+
+    [TestMethod]
+    public void RecordPropertiesShouldHaveCorrectAccessModifiersBasedOnDefault()
+    {
+        // Assign
+        var source =
+            $$"""
+            public record Person(string FirstName, string LastName)
+            {
+            }
+            """;
+
+        // Act
+        var types = TestHelper.VisitSyntaxTree(source, "CS0067");
+
+        // Assert
+        types[0].Properties[0].Modifiers.Should().HaveFlag(Modifier.Protected);
+        types[0].Properties[1].Modifiers.Should().HaveFlag(Modifier.Public);
+        types[0].Properties[2].Modifiers.Should().HaveFlag(Modifier.Public);
+    }
+
+    [TestMethod]
+    public void SealedRecordPropertiesShouldHaveCorrectAccessModifiers()
+    {
+        // Assign
+        var source =
+            $$"""
+            public sealed record Person(string FirstName, string LastName)
+            {
+            }
+            """;
+
+        // Act
+        var types = TestHelper.VisitSyntaxTree(source, "CS0067");
+
+        // Assert
+        types[0].Properties[0].Modifiers.Should().HaveFlag(Modifier.Private);
+        types[0].Properties[1].Modifiers.Should().HaveFlag(Modifier.Public);
+        types[0].Properties[2].Modifiers.Should().HaveFlag(Modifier.Public);
+    }
 }