Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set record property modifiers correctly #13

Merged

Conversation

eNeRGy164
Copy link
Member

Record properties (e.g. positional parameters, EqualityContract) were not detecting the correct accessibility modifiers.

Refactored SourceAnalyzer to improve record declaration processing and added tests for property access modifiers.

  • SourceAnalyzer.cs: Introduced ProcessRecordSymbolInformation, ProcessConstructors, and ProcessProperties methods.
  • RecordDeclarationTests.cs: Added tests for property access modifiers in records.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@eNeRGy164 eNeRGy164 added the bug Something isn't working label Aug 30, 2024
@eNeRGy164 eNeRGy164 merged commit 07bae84 into dendrodocs:main Aug 30, 2024
3 checks passed
@eNeRGy164 eNeRGy164 deleted the set-record-property-modifiers-correctly branch August 30, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant