Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Newtonsoft.Json with System.Text.Json #23

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Replace Newtonsoft.Json with System.Text.Json #23

merged 8 commits into from
Oct 7, 2024

Conversation

eNeRGy164
Copy link
Member

Fixes #19

Type of change

No visible change

How Has This Been Tested?

  • Extensive unit testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@eNeRGy164 eNeRGy164 added the code quality Improvements to code style, structure, or coverage without adding new features or fixing bugs. label Sep 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10891847487

Details

  • 0 of 3 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 65.996%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/DendroDocs.Tool/Program.cs 0 3 0.0%
Totals Coverage Status
Change from base Build 10880299141: 0.1%
Covered Lines: 453
Relevant Lines: 645
💛 - Coveralls

@eNeRGy164 eNeRGy164 added the enhancement New feature or request label Sep 16, 2024
@eNeRGy164 eNeRGy164 requested a review from YVbakker September 25, 2024 19:38
@eNeRGy164 eNeRGy164 merged commit 6a9f06d into dendrodocs:main Oct 7, 2024
4 checks passed
@eNeRGy164 eNeRGy164 deleted the update-json-lib branch October 7, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YVbakker YVbakker Awaiting requested review from YVbakker

Assignees
No one assigned
Labels
code quality Improvements to code style, structure, or coverage without adding new features or fixing bugs. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use System.Text.Json instead of Newtonsoft.Json
2 participants
@eNeRGy164 @coveralls