Skip to content

Commit

Permalink
Add 'dupbuild' as deprecated warning
Browse files Browse the repository at this point in the history
Fixup after 8f47d5a

Since v1.12 ninja breaks compatibility with existing generators,
particularly bob build system, which always invokes ninja with
-w dupbuild=err

See: https://github.com/ARM-software/bob-build/blob/master/bob.bash

This patch should also be applied to the 'release' branch.
  • Loading branch information
Daniel Levin committed Aug 28, 2024
1 parent f220dc5 commit a91a30e
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/ninja.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1230,6 +1230,10 @@ bool WarningEnable(const string& name, Options* options) {
} else if (name == "phonycycle=warn") {
options->phony_cycle_should_err = false;
return true;
} else if (name == "dupbuild=err" ||
name == "dupbuild=warn") {
Warning("deprecated warning 'dupbuild'");
return true;
} else if (name == "depfilemulti=err" ||
name == "depfilemulti=warn") {
Warning("deprecated warning 'depfilemulti'");
Expand Down

0 comments on commit a91a30e

Please sign in to comment.