Use requires for conditional JLD dependency

[MikeInnes]

This is much more robust to changes in package state, as well as helping to support the package in deployments (e.g. JuliaBox and JuliaPro).

[CarloLucibello]

you may also want to take care of the SpecialFunctions.jl conditional dependence added in commit 557ffbd

[MikeInnes]

That would be a good idea, although it's not that clear to me how that patch works; where are the functions being imported and overloaded?

[CarloLucibello]

mhmh, I don't know. In julia 0.6 erf is still exported by Base, altough deprecated.

In AutoGrad a similar conditional dependence was also made, but there you have

+if VERSION >= v"0.6.0" && Pkg.installed("SpecialFunctions") != nothing
-    Pkg.add("SpecialFunctions")
     eval(Expr(:using,:SpecialFunctions))
 end

[denizyuret]

In Knet the conditional stuff is in: https://github.com/denizyuret/Knet.jl/blob/master/src/unary.jl#L65 Just grep for SpecialFunctions in AutoGrad and/or Knet...

…

On Thu, Oct 5, 2017 at 4:47 PM Carlo Lucibello ***@***.***> wrote: mhmh, I don't know. In julia 0.6 erf is still exported by Base, altough deprecated. In AutoGrad a similar conditional dependence was also made, but there you have +if VERSION >= v"0.6.0" && Pkg.installed("SpecialFunctions") != nothing- Pkg.add("SpecialFunctions") eval(Expr(:using,:SpecialFunctions)) end — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#172 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvNpjX3_U-5aMpYnbLqA7kmz0o8OQG7ks5spN3egaJpZM4Pu9hZ> .

[MikeInnes]

It's slightly tricky to combine the requires block with the version check in this case. I may do that as a separate PR.

[denizyuret]

I get the following error in Julia4, is this easy to fix?

ERROR: LoadError: UndefVarError: @init not defined

[denizyuret]

Just realized @MikeInnes's package only supports Julia 6+. Seems to not complain in Julia 5 but not sure if it is functional. I could do a conditional thing where I have the old code for Julia < 6 and Mike's code for >= 6. Will that fix #128 ?

[MikeInnes]

Requires master only supports 0.6, but there are versions for 0.4 and 0.5 as well. 0.4 is probably stale at this point but may be easy to fix.

I could do a conditional thing where I have the old code for Julia < 6 and Mike's code for >= 6. Will that fix #128 ?

For version 0.6, yes. That would be fine by me.

[denizyuret]

Hm, at some point you decided not to export @init in julia4, any reason?

[MikeInnes]

Honestly, no idea. If you add it back and it doesn't cause issues I can re-tag for 0.4.

[denizyuret]

@MikeInnes do conditional dependencies work in Julia 1.0? It seems like if a dependency is not in Project.toml we get a big warning even if it is installed asking why we are using a package we did not declare as a requirement...

[MikeInnes]

Yes, but you can't do using Foo. You have to change to using .Foo or similar.