feat: add shim for Deno.consoleSize() #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jonbcard
force-pushed
the
feat-console-size
branch
from
e819d87
to
b8c62e5
Compare
dsherret
reviewed
Jan 28, 2024
| ///<reference path="../lib.deno.d.ts" /> | ||
|
|
||
| export const consoleSize: typeof Deno.consoleSize = function consoleSize() { | ||
| const { columns, rows } = process.stdout; |
There was a problem hiding this comment.
Just did some testing and these will be undefined when stdout is piped. I'll update this PR to do what we do with consoleSize in Deno.
There was a problem hiding this comment.
Actually, I'll merge and open a new PR.
There was a problem hiding this comment.
Ahh! Good catch. Thanks!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shim for
Deno.consoleSize()https://deno.land/api@v1.39.0?s=Deno.consoleSize