Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update hcl2json to version 0.6.4 #10952

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Update hcl2json to version 0.6.4 #10952

merged 2 commits into from
Nov 19, 2024
+5 −4

Conversation

Zawadidone
Copy link
Contributor

@Zawadidone Zawadidone commented Nov 18, 2024 •
edited
Loading

What are you trying to accomplish?

Fix the issue #10315 by using the latest version of hcl2json

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@github-actions github-actions bot added the L: terraform Terraform packages label Nov 18, 2024
@Zawadidone Zawadidone marked this pull request as ready for review November 18, 2024 10:13
@Zawadidone Zawadidone requested a review from a team as a code owner November 18, 2024 10:13
sachin-sandhu
sachin-sandhu approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@sachin-sandhu sachin-sandhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for release

@sachin-sandhu sachin-sandhu merged commit 1dc68ee into dependabot:main Nov 19, 2024
37 checks passed
@sachin-sandhu
Copy link
Contributor

@Zawadidone , thank you for the fix, really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sachin-sandhu sachin-sandhu sachin-sandhu approved these changes

Assignees
No one assigned
Labels
L: terraform Terraform packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zawadidone @sachin-sandhu