Fix crontab for cross platform support. #3829
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes crontab failing to recognize the existing cronjobs when running from Windows and connecting to a say a Linux server. It would lead to new existing sections not being found, and new ones being added each time it was run. This was due to trying to explode the crontab lines with
PHP_EOL, as on a windows system, it would be looking for\r\nnewlines in the crontab. However, the crontab was coming from a linux system, and the newlines would be\n.This fix now looks for all types of newlines to split the crontab lines by.
Bug fix #…?
New feature?
BC breaks?
Tests added?
Docs added?