Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNA 페이지 히스토리 없을 때 뒤로가기 대응 #439

Merged
merged 3 commits into from
Aug 26, 2023

Conversation

hyesungoh
Copy link
Member

🤔 해결하려는 문제가 무엇인가요?

DNA 페이지를 처음으로 방문했을 때, 뒤로가기를 누르면 (back) 이 동작하지 않는 문제가 있었어용

🎉 변경 사항

history length를 기준으로 뒤로가거나, result로 보내용

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (8a10f29) 89.34% compared to head (6e63486) 89.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #439   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files          44       44           
  Lines         338      338           
  Branches       61       61           
=======================================
  Hits          302      302           
  Misses         36       36           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link

Bundle Sizes

Compared against 8a10f29

Route: No significant changes found

Dynamic import: No significant changes found

@hyesungoh hyesungoh merged commit 83b9972 into main Aug 26, 2023
12 checks passed
@hyesungoh hyesungoh deleted the feature/dna-page-pop-state branch August 26, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants