Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add command to copy container image #2177

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

add command to copy container image #2177

wants to merge 7 commits into from

Conversation

adelowo
Copy link

@adelowo adelowo commented Jul 29, 2023

Fixes #2164

I have added the ctrl-y command to copy the container image when you are in the pod view.

derailed
derailed requested changes Nov 12, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adelowo Nice work! Thank you for this PR. Just a few small picks..,

internal/view/container.go Outdated Show resolved Hide resolved
internal/view/container.go Outdated Show resolved Hide resolved
@derailed derailed added enhancement New feature or request needs-tlc Pr needs additional updates labels Nov 12, 2023
derailed
derailed requested changes Dec 6, 2023
View reviewed changes
Copy link
Owner

@derailed derailed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adelowo Thank you for the update Lanre!
It looks like there is a merge conflict in go.sum that hasn't been resolved. Not sure that this pr warrants dependencies updates? Perhaps best to remove it.
Also could you update the pr description since this action is available in container view and not pod view. Thank you!

@adelowo adelowo force-pushed the add_command_to_copy_image_id branch from f0173e6 to c8eff7b Compare December 8, 2023 12:19
@adelowo
Copy link
Author

adelowo commented Dec 8, 2023

@adelowo Thank you for the update Lanre! It looks like there is a merge conflict in go.sum that hasn't been resolved. Not sure that this pr warrants dependencies updates? Perhaps best to remove it. Also could you update the pr description since this action is available in container view and not pod view. Thank you!

apologies. I messed that up. Resolved it all now

@adelowo adelowo requested a review from derailed December 8, 2023 12:22
@derailed
Copy link
Owner

@adelowo Looks like we still have a conflict left... Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarekTyshchenko YarekTyshchenko YarekTyshchenko left review comments

@derailed derailed Awaiting requested review from derailed

Assignees
No one assigned
Labels
enhancement New feature or request needs-tlc Pr needs additional updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Copy the image of a container to clipboard
3 participants
@adelowo @derailed @YarekTyshchenko