Add support for coloured pretty print JSON output #2999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thank you for this great project - it is helping lot of people to improve their productivity with kubernetes management.
This PR is adding colored, prettified JSON output to k9s.
I tried to follow the conventions in the initial code. I only added a new package (jsonpretty) responsible with writing modified JSON log lines.
The coloring is based on simple rules for value type and on simple regex rules for map keys and values.
I didn't implement a configuration section for the coloring rules yet, the rules are hardcoded for now. However, if you like the idea and give me few hints, I can also extend the configuration with these rules as part of this PR.
Having regexes in the configuration files doesn't look particularly well suited for consumption, maybe we can implement something smarter like CEL rules or simple OR of list entries.
For the same reason (unfinished work) I didn't extend the documentation yet.