Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add moving average (by DataArray.rolling) to qlook commands #191

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

ShinjiFujita
Copy link
Contributor

@ShinjiFujita ShinjiFujita commented Jul 31, 2024

Closes #186.

@astropenguin astropenguin changed the title Update qlook.py (issue186) Add moving average (by DataArray.rolling) to qlook commands Aug 3, 2024
Copy link
Member

@astropenguin astropenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update! I would like to ask you to fix the following things:

  • Order (position) of the option: rolling_time option is for analysis, so it should be placed under # options for analysis (above source_radius: str = "60 arcsec",). Could you move the line?
  • Description of the option: Could you add a short description about the rolling_time option in the docstring?
  • Which data to be rolled: It seems that da_sub is not suitable data to be rolled because its timestamps are no longer continuous. We discussed in a DESHIMA meeting that rolling should be applied just after loading a DEMS, i.e., applied to da = select.by(da, "state", exclude="GRAD").

@astropenguin astropenguin added the feature New feature or request label Aug 5, 2024
@astropenguin astropenguin added this to the v2024.8 milestone Aug 5, 2024
@astropenguin astropenguin self-requested a review August 6, 2024 11:15
Copy link
Member

@astropenguin astropenguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! It looks good for me.

@astropenguin astropenguin merged commit 8faf1fa into main Aug 6, 2024
4 checks passed
@astropenguin astropenguin deleted the issue186 branch August 6, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add moving average (by DataArray.rolling) to qlook commands
2 participants