Make whitespace invalid in token names #216
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dtcg-tr ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ChucKN0risK
changed the title
|
This is a major reversal of past choices. |
dhwlz
reviewed
Jul 11, 2023
| "$value": 33, | ||
| "$type": "number" | ||
| }, | ||
| "Token cuatro": { | ||
| "Token-cuatro": { |
There was a problem hiding this comment.
Suggested change
| "Token-cuatro": { | |
| "token-cuatro": { |
dhwlz
reviewed
Jul 11, 2023
| @@ -17,6 +17,8 @@ Note: The `$type` property has been added to ensure this example is valid. Pleas | |||
|
|
|||
| </aside> | |||
|
|
|||
| The name of your design token must not include any whitespace. Otherwise your design token is considered as invalid. | |||
There was a problem hiding this comment.
Suggested change
| The name of your design token must not include any whitespace. Otherwise your design token is considered as invalid. | |
| Design tokens are written in kebab-case. Otherwise your design token is considered as invalid. |
There was a problem hiding this comment.
I think this should be left as is. Kebab-case is only one way of avoiding whitespace... snake_case or CamelCase are fine too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've decided to consider a token as invalid when its name includes whitespaces.
design-token.mdfile