Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump artifact-related actions to v4 #513

Merged
merged 6 commits into from
Aug 13, 2024
Merged

Conversation

sergiou87
Copy link
Member

@sergiou87 sergiou87 commented Jul 29, 2024

  • Upgrade upload-artifacts and download-artifacts to v4
  • In order to do that, bump the GLIBC requirements by using Ubuntu 20.04 to build Dugite
  • I noticed macos-11 runners are not available anymore, so I bumped those to macos-12 and we will use Xcode 13.1 from now on (it's the oldest one available, for maximum compatibility).

@sergiou87
Copy link
Member Author

Hey @theofficialgman 👋

Version 3 of the actions upload-artifacts and download-artifacts is gonna be deprecated soon, so we want to move to v4. However, v4 requires Node 20 which in turn requires GLIBC 2.28.

Do you still need GLIBC 2.17 for the Linux builds or is it now a good time to bump them to 2.28? If 2.17 is still required, could you try to fix this issue? Otherwise, we lack the time and expertise to make it happen… 😕

Thanks in advance 🙏

@theofficialgman
Copy link
Contributor

Do you still need GLIBC 2.17 for the Linux builds or is it now a good time to bump them to 2.28?

That's a question up to @shiftkey

@shiftkey
Copy link
Member

I think I'm good to do this upgrade, and handle the comms when we publish the first version of the Linux builds that need a later glibc...

@theofficialgman
Copy link
Contributor

Ok. @sergiou87 then just bump ubuntu:18.04 to ubuntu:20.04 in the ci.yml in all 3 places

@sergiou87 sergiou87 closed this Aug 12, 2024
@sergiou87 sergiou87 reopened this Aug 12, 2024
@sergiou87 sergiou87 merged commit da7def2 into master Aug 13, 2024
12 checks passed
@sergiou87 sergiou87 deleted the bump-artifact-actions-v4 branch August 13, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants