-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add particle species in Beam classes and update tracking methods #276
Open
cr-xu
wants to merge
32
commits into
master
Choose a base branch
from
231-add-particle-species-in-particlebeam
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cr-xu
changed the title
231 Add particle species in particlebeam
231 Add particle species in Beam classes and update tracking methods
Oct 14, 2024
jank324
changed the title
231 Add particle species in Beam classes and update tracking methods
Add particle species in Beam classes and update tracking methods
Oct 15, 2024
cr-xu
commented
Oct 15, 2024
I just realized that I still need to take the particle charges into account for the cavities/elements with electric fields. So this should probably wait until #278 is merged. |
…ameters on the fly
This reverts commit 7e8d653.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the option to track with different particle species.
Changes:
Species
Class, containing the name, charge, and mass information for the particles. Some basic species are pre-defined, with the possibility to define custom mass-to-charge ratio particles.transfer_map
methods and thecompute_relativistic_factors
need two arguments:[energy, particle_mass_eV]
withparticle_mass_eV
default to electron massspecies
and a new propertymass_eV
Motivation and Context
Types of changes
Checklist
flake8
(required).pytest
tests pass (required).pytest
on a machine with a CUDA GPU and made sure all tests pass (required).Note: We are using a maximum length of 88 characters per line.