Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display runs count in ProjectCard (ET-314) #9600

Merged
merged 6 commits into from
Jul 2, 2024
Merged

Conversation

johnkim-det
Copy link
Contributor

Ticket

ET-314

Description

ProjectCard should display runs count instead of experiments count when Flat Runs feature flag is on.

Test Plan

With Flat Runs feature flag on

  • ProjectCards on dashboard should display number of runs, and the tooltip should say "runs" on hover
  • Same on Workspace Details pages
    With Flat Runs feature flag on, they should still show experiments.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@johnkim-det johnkim-det requested a review from a team as a code owner July 2, 2024 14:04
@johnkim-det johnkim-det requested a review from ashtonG July 2, 2024 14:04
@cla-bot cla-bot bot added the cla-signed label Jul 2, 2024
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit a2c5787
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6684347462908c00080bfb0e
😎 Deploy Preview https://deploy-preview-9600--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.64%. Comparing base (84072f6) to head (a2c5787).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9600      +/-   ##
==========================================
- Coverage   51.36%   46.64%   -4.72%     
==========================================
  Files        1252      929     -323     
  Lines      152174   123056   -29118     
  Branches     3024     3051      +27     
==========================================
- Hits        78158    57404   -20754     
+ Misses      73858    65496    -8362     
+ Partials      158      156       -2     
Flag Coverage Δ
harness ?
web 48.61% <100.00%> (+0.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/ProjectCard.tsx 100.00% <100.00%> (+100.00%) ⬆️
webui/react/src/types.ts 99.68% <100.00%> (+<0.01%) ⬆️

... and 328 files with indirect coverage changes

@johnkim-det johnkim-det requested a review from ashtonG July 2, 2024 17:04
@johnkim-det johnkim-det merged commit 3095703 into main Jul 2, 2024
81 of 94 checks passed
@johnkim-det johnkim-det deleted the johnkim/ET-314 branch July 2, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants