Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set signerOrProvider optional #764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rubilmax
Copy link

@Rubilmax Rubilmax commented Sep 7, 2022

Hi,

Here's the Contract constructor signature from ethers v5:

constructor(addressOrName: string, contractInterface: ContractInterface, signerOrProvider?: Signer | Provider)

I was thus wondering why TypeChain forces signerOrProvider to be defined, whereas ethers does not (and we've got a use-case where we don't want to define a signer nor a provider)

So here's a quick PR to fix this :)

@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2022

⚠️ No Changeset found

Latest commit: c169fd2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@MerlinEgalite MerlinEgalite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥

@mihaic195
Copy link

mihaic195 commented Sep 12, 2022

Thanks for this! Much needed! @krzkaczor

@iainnash
Copy link
Contributor

+1 to this

@mihaic195
Copy link

This has been open for almost 2 months and the problem is still there.
@krzkaczor can we get this merged, please?

@Rubilmax
Copy link
Author

Rubilmax commented Jun 5, 2023

Up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants