-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set signerOrProvider optional #764
base: master
Are you sure you want to change the base?
Set signerOrProvider optional #764
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🔥
Thanks for this! Much needed! @krzkaczor |
+1 to this |
This has been open for almost 2 months and the problem is still there. |
Up |
Hi,
Here's the Contract constructor signature from ethers v5:
I was thus wondering why TypeChain forces
signerOrProvider
to be defined, whereasethers
does not (and we've got a use-case where we don't want to define a signer nor a provider)So here's a quick PR to fix this :)