Switch to WeakMap and String objects to avoid memory leak. Fixes #20 and #34. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a new PR here to start the discussion on solving #20 again.
PR Switch to a WeakMap to avoid memory leak #23 aims to solve SSR Memory leak #20 by switching to WeakMap, but it uses string primitives as keys and will throw
TypeError: Invalid value used as weak map key.PR Switch sanitization to a Set and add cleanup #36 switches to a Set for storing the sanitized strings, but we risk evicting strings from the set before using them, changing the output of
vhtml()to escaped text.This PR switches to WeakMap (as in #23), but uses string objects as keys. This will have a performance impact, and change the output from
vhtml()from string primitives to string objects.The question is if it's worth taking the performance impact to solve both #20 and #34.