#1309: Improve plugin managment

[diiinesh]

Solves devonfw/ide#1309
Improves plugin managment by solving the error of installing duplicate plugins

[coveralls]

Pull Request Test Coverage Report for Build 9221194472

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 20 unchanged lines in 1 file lost coverage.
• Overall coverage increased (+0.09%) to 59.627%

---

Files with Coverage Reduction	New Missed Lines	%
com/devonfw/tools/ide/tool/PluginBasedCommandlet.java	20	44.71%

Totals
Change from base Build 9210541439:	0.09%
Covered Lines:	4670
Relevant Lines:	7545

---

💛 - Coveralls

[mvomiero]

except the unused import and maybe the refactoring for the assert(), LGTM :)

[diiinesh]

After reviewing and analyzing issue devonfw/ide#1309, I found that the issue of duplicate plugins, caused by not properly removing the plugins folder after every tool update, does not exist in IDEasy.
In IDEasy, the plugin folder is removed correctly, and the plugins are reinstalled automatically.

This behavior has been thoroughly tested for both Eclipse and IntelliJ.

Additionally, I have made modifications to PluginBasedCommandlet.java. These modifications introduce two PluginMaps: one with plugin IDs as keys and another with plugin names as keys.
The function getPlugin was adjusted to make it possible to look for a plugin either using id or name as the argument.

[mvomiero]

Thank you for your implementation, LGTM 🌹

[hohwille]

@diiinesh thanks for your rework, improvements and testing on this feature.
I took your approach further to encapsulate the plugin mapping into the new PluginMaps class. See my review comments with the suggested code-changes.
The JUnit would still need adoption that I can not do reliably in the browser.

After all I am thinking that we might have over-complicated things with adding the additional by-id map:

• some plugins may not even have an ID but that is covered in the code
• eclipse plugin ID is a comma separated list of feature IDs. In case you have more than one feature overriding can become problematic: If you want to override the plugin configuration but want to have a more or less features, the plugin ID will change and therefore you are not technically overriding things even if you pick the same filename «plugin».properties. Therefore it is impossible to reduce the number of features but only add more features.
  Maybe always using the mapByName for getPlugins() would be a better solution...

[hohwille]

@diiinesh there are test errors:

[ERROR] com.devonfw.tools.ide.commandlet.UpdateCommandletTest.testRunPullSettingsAndUpdateSoftware -- Time elapsed: 0.032 s <<< ERROR!
java.lang.NullPointerException: Cannot invoke "com.devonfw.tools.ide.tool.PluginMaps.getPlugins()" because "this.pluginsMap" is null
	at com.devonfw.tools.ide.tool.PluginBasedCommandlet.doInstall(PluginBasedCommandlet.java:158)

Please have a look. Thanks.

[hohwille]

@diiinesh thanks for the update. You finally nailed it 👍