Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fechas-importantes): Mitigar respuestas NaN, undefined, invalid date #742

Merged

Conversation

segovia-no
Copy link
Contributor

Descripción

Fix que mitiga las conversiones erróneas a NaN, undefined e Invalid date usando el script fechas importantes.

  • Matcher actualizado para obtener la fecha requerida desde el mensaje del usuario
  • Pasar la fecha como string directamente a MomentJS para su parsing.
  • Unit tests básicos para detección de NaN, undefined o Invalid Date en todas las fechas soportadas

@segovia-no segovia-no changed the title Sego/fix fechas importantes nan responses fix(fechas-importantes): Mitigar respuestas NaN, undefined, invalid date Sep 18, 2023
@segovia-no segovia-no marked this pull request as ready for review September 18, 2023 18:25
@gmq gmq merged commit 5145c8f into devschile:master Sep 21, 2023
2 checks passed
@segovia-no segovia-no deleted the Sego/fix-fechas-importantes-nan-responses branch September 21, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants