fix: Do not evaluate skipApproval on approval page (#3086)

Signed-off-by: MM53 <28218664+MM53@users.noreply.github.com>
dexidp · Feb 13, 2024 · a0cf8b2 · a0cf8b2
1 parent 79d5874
commit a0cf8b2
Showing 1 changed file with 0 additions and 6 deletions.
diff --git a/server/handlers.go b/server/handlers.go
@@ -628,12 +628,6 @@ func (s *Server) handleApproval(w http.ResponseWriter, r *http.Request) {
 
 	switch r.Method {
 	case http.MethodGet:
-		// TODO: `finalizeLogin()` now sends code directly to client without going through this endpoint,
-		//		 the `if skipApproval { ... }` block needs to be removed after a grace period.
-		if s.skipApproval {
-			s.sendCodeResponse(w, r, authReq)
-			return
-		}
 		client, err := s.storage.GetClient(authReq.ClientID)
 		if err != nil {
 			s.logger.Errorf("Failed to get client %q: %v", authReq.ClientID, err)